Skip to content

[release/8.0] Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator #13706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release/8.0] Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator #13706

wants to merge 1 commit into from

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jul 16, 2025 •
edited by LeafShi1
Loading

Back port PR10243 to release/8.0

Fixes #7154 , #13672 on .Net 8.0

Microsoft Reviewers: Open in CodeFlow

Proposed changes

  • Creates a new switch that allows developers to configure their application to make the starting index of rows/cells in DataGridView to be read by Narrator from 1, instead of 0;
  • Adds checks on rows and cells of DataGridView to see if the switch is true. If true, starting index of rows/cells will be 1, instead of 0.

Customer Impact

  • Developers will be able to configure their WinForms DataGridView rows/cells to be read by Narrator from index 1, instead of 0.

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Manual (Narrator, NVDA)
  • Unit tests

@Epica3055 Epica3055 requested a review from a team as a code owner July 16, 2025 09:17
@Epica3055 Epica3055 changed the title Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator [release/8.0] Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator Jul 17, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed labels Jul 23, 2025
ricardobossan
ricardobossan approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Epica3055 Epica3055 added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 24, 2025
@LeafShi1
Copy link
Member

LeafShi1 commented Aug 6, 2025

This fix does not require backporting to .net8.0

@LeafShi1 LeafShi1 closed this Aug 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed waiting-review This item is waiting on review by one or more members of team labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardobossan ricardobossan ricardobossan approved these changes

@KlausLoeffelmann KlausLoeffelmann Awaiting requested review from KlausLoeffelmann

@merriemcgaw merriemcgaw Awaiting requested review from merriemcgaw

Assignees

@Epica3055 Epica3055

Labels
🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Epica3055 @LeafShi1 @ricardobossan