Skip to content

[zscaler_zia] Update response format version numbers #10741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[zscaler_zia] Update response format version numbers #10741

merged 2 commits into from
Aug 8, 2024

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Aug 8, 2024

Proposed commit message

[zscaler_zia] Update response format version numbers (#)

Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
@chrisberkhout chrisberkhout added Integration:zscaler_zia Zscaler Internet Access bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 8, 2024
@chrisberkhout chrisberkhout self-assigned this Aug 8, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner August 8, 2024 12:55
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion. LGTM Otherwise 👍🏼
Thanks for taking care of this!

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

Copy link

@chrisberkhout chrisberkhout merged commit 7b5d67c into elastic:main Aug 8, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the zscaler-zia-response-format-versions-fix branch August 8, 2024 13:35
@elasticmachine
Copy link

Package zscaler_zia - 3.0.4 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Response formats were often updated without incrementing the
corresponding version number.

These have been updated to reflect the number of changes made
to the response formats, as summarized in the following table.

| Data stream      | Was | Now | Note                                |
|------------------|-----|-----|-------------------------------------|
| Alerts           |  v1 |  v1 | Correct.                            |
| Audit Log        |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| DNS Log          |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Endpoint DLP Log |  v1 |  v1 | Correct. Pattern added in 78f3eae.  |
| Firewall Log     |  v1 |  v2 | Fixed. Pattern updated in 78f3eae.  |
| Tunnel Log       |  v1 |  v2 | Fixed. Patterns updated in 78f3eae. |
| Web Log          |  v2 |  v5 | Fixed. Pattern updated in...        |
|                  |     |     | 3418fe2, a9783c8, 78f3eae, dbf3f74. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants