Skip to content

Updated description on ssl node in data_stream to be uniform and include links to online documentation for integrations owned by obs-infraobs-integrations #12727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

Updated description on ssl node in data_stream to be uniform and include links to online documentation for integrations owned by obs-infraobs-integrations #12727

merged 2 commits into from
Feb 20, 2025

Conversation

StacieClark-Elastic
Copy link
Member

Proposed commit message

Updated ssl node descriptions in data_streams owned by obs-infraobs-integrations. Includes all the datastreams for aws. One is owned by all security-service-integrations and one is owned by obs-ds-hosted-services. This commit updates or adds descriptions to the ssl node to be uniform and to include links to online documentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Originally, we update the descriptions on all the files. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by obs-infraobs-integrations, plus all the aws streams.
One is owned by all security-service-integrations and one is owned by obs-ds-hosted-services. As such the only verification would be to check that was what updates is uniform.


git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml

Related issues

@StacieClark-Elastic StacieClark-Elastic added Integration:aws AWS Integration:vsphere VMware vSphere Integration:hadoop Hadoop Integration:kafka_log Custom Kafka Logs Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Feb 11, 2025
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703 branch from 31af747 to 6a0ad16 Compare February 11, 2025 19:59
efd6
efd6 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSI files LGTM

@StacieClark-Elastic StacieClark-Elastic marked this pull request as ready for review February 11, 2025 20:56
@StacieClark-Elastic StacieClark-Elastic requested review from a team as code owners February 11, 2025 20:56
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 11, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ishleenk17
Copy link
Member

@StacieClark-Elastic : Thanks for the work here.
Please note there are many more Integrations owned by Infraobs team that use this description. They might need the same change as well.

@StacieClark-Elastic
Copy link
Member Author

This is targeted to data_streams. Changes to package/*/manifest.yml will take more focused review so that will be in a different PR.

@StacieClark-Elastic StacieClark-Elastic self-assigned this Feb 13, 2025
Kavindu-Dodan
Kavindu-Dodan approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval for AWS module.

@StacieClark-Elastic
[bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703
de54b67 
Updated ssl node descriptions in datastreams owned by obs-infraobs-integrations. Includes a datastream in aws that is owned by security-service-integrations and obs-ds-hosted-services
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703 branch from f1e18a9 to de54b67 Compare February 18, 2025 14:25
ishleenk17
ishleenk17 reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In these Integrations, I see that 9.0.0 Kibana version is being removed. Why is that ?

@StacieClark-Elastic
bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703
aa3129a 
fixed a missed merge of version line from main
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703 branch from 077130e to aa3129a Compare February 19, 2025 14:34
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @StacieClark-Elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@StacieClark-Elastic StacieClark-Elastic enabled auto-merge (squash) February 19, 2025 20:16
@StacieClark-Elastic StacieClark-Elastic requested review from a team and ishleenk17 February 19, 2025 20:22
@StacieClark-Elastic StacieClark-Elastic merged commit 476a42f into elastic:main Feb 20, 2025
6 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package aws - 2.41.1 containing this change is available at https://epr.elastic.co/package/aws/2.41.1/

@elastic-vault-github-plugin-prod
Copy link

Package hadoop - 1.8.1 containing this change is available at https://epr.elastic.co/package/hadoop/1.8.1/

@elastic-vault-github-plugin-prod
Copy link

Package kafka_log - 1.8.1 containing this change is available at https://epr.elastic.co/package/kafka_log/1.8.1/

@elastic-vault-github-plugin-prod
Copy link

Package vsphere - 1.18.1 containing this change is available at https://epr.elastic.co/package/vsphere/1.18.1/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@StacieClark-Elastic @flexitrev
Updated description on ssl node in data_stream to be uniform and incl…
23edcf9 
…ude links to online documentation for integrations owned by obs-infraobs-integrations (#12727)

* [bugfix/update-ssl-option-descriptions-obs-infraobs-integrations-12703
Updated ssl node descriptions in datastreams owned by obs-infraobs-integrations. Includes a datastream in aws that is owned by security-service-integrations and obs-ds-hosted-services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@efd6 efd6 efd6 approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@StacieClark-Elastic StacieClark-Elastic

Labels
bugfix Pull request that fixes a bug issue Integration:aws AWS Integration:hadoop Hadoop Integration:kafka_log Custom Kafka Logs Integration:vsphere VMware vSphere Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation changes for SSL node for integrations owned by obs-infraobs-integrations
6 participants
@StacieClark-Elastic @ishleenk17 @elasticmachine @andrewkroh @Kavindu-Dodan @efd6