Skip to content

[O365 Metrics] Add field site_type missing in onedrive data streams #13139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2025
Merged

[O365 Metrics] Add field site_type missing in onedrive data streams #13139

merged 7 commits into from
Apr 15, 2025

Conversation

Linu-Elias
Copy link
Contributor

Proposed commit message

Field site_type missing from the below data streams

  • onedrive_usage_account_counts
  • onedrive_usage_file_counts
  • onedrive_usage_storage

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

  • onedrive_usage_storage
    image

  • onedrive_usage_account_counts
    image

  • onedrive_usage_file_counts
    image

@Linu-Elias Linu-Elias requested a review from a team as a code owner March 17, 2025 13:34
@andrewkroh andrewkroh added Integration:o365_metrics Microsoft Office 365 Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] bugfix Pull request that fixes a bug issue labels Mar 17, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 18, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

lucian-ioan
lucian-ioan reviewed Mar 19, 2025
View reviewed changes
lucian-ioan
lucian-ioan approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit description.

ritalwar
ritalwar reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we've tested for both data duplication and missing events after adding this new field, ensuring we don't overlook any dimension fields.

packages/o365_metrics/changelog.yml Outdated
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.6.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this now that we have other versions available.

packages/o365_metrics/changelog.yml Outdated
- version: "0.6.7"
changes:
- description: Add `site_type` field for `onedrive_usage_account_counts`, `onedrive_usage_file_counts` and `onedrive_usage_storage` data streams.
type: bugfix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: bugfix
type: enhancement

ritalwar
ritalwar reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please update a sample_event.json file for all the updated data streams?
Additionally, could you include system test cases for them, similar to how it's being done for the new data streams in the package?

@Linu-Elias
Copy link
Contributor Author

I hope we've tested for both data duplication and missing events after adding this new field, ensuring we don't overlook any dimension fields.

yes, I have tested for data duplication and data loss cases after adding site_type.

@Linu-Elias
Copy link
Contributor Author

Could you also please update a sample_event.json file for all the updated data streams? Additionally, could you include system test cases for them, similar to how it's being done for the new data streams in the package?

Updated the sample_event.json file for all the affected data streams. I am planning to include system test cases in a separate PR.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
36.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@Linu-Elias Linu-Elias merged commit bb73f87 into elastic:main Apr 15, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package o365_metrics - 0.11.1 containing this change is available at https://epr.elastic.co/package/o365_metrics/0.11.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucian-ioan lucian-ioan lucian-ioan approved these changes

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:o365_metrics Microsoft Office 365 Metrics Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Linu-Elias @elasticmachine @lucian-ioan @ritalwar @andrewkroh