Skip to content

[Cloud Posture] - remove state from csp-rule templates #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 10, 2023
Merged

[Cloud Posture] - remove state from csp-rule templates #4878

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
68a2f82
remove `muted` and `enabled fields from csp_rule_template`
ofiriro3 Dec 21, 2022
56a939c
Change the migration version to 8.7.0
ofiriro3 Dec 21, 2022
653e742
Merge branch 'remove_state_from_csp_rule_template' of github.com:ofir…
ofiriro3 Dec 22, 2022
f768481
adding log message
ofiriro3 Dec 22, 2022
5151579
merging main
ofiriro3 Jan 2, 2023
8727e1a
Fixing versions
ofiriro3 Jan 2, 2023
15e73ef
merging main to mine
ofiriro3 Jan 3, 2023
d006692
merging main to mine
ofiriro3 Jan 9, 2023
f37ca75
merging main to mine
ofiriro3 Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merging main to mine
  • Loading branch information
@ofiriro3
ofiriro3 committed Jan 3, 2023
commit 15e73eff043774317f9d1ce9bd929aa020b76643
7 changes: 6 additions & 1 deletion packages/cloud_security_posture/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
# newer versions go on top
- version: "1.2.1"
- version: "1.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear version bump.
can it be 1.1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go over it yet, it is still in draft.

But anyway, it's an important comment.

For sure it is not 1.2.2, I am not sure if we want it to be 1.1.3, since this change is a breaking change.
We deprecate two of the rules template fields.
Usually, when deprecating fields you bump either the major or the minor depending on the change and the impact on customers.

So what do you suggest in this case?

I think that 1.2.0 should be Ok since it is a deprecation, but it doesn't impact customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.3 - was decided.

changes:
- description: Remove state from csp rule template
type: enhancement
link: https://github.com/elastic/integrations/pull/4878
- version: "1.2.1"
changes:
- description: Update CSP mapping
type: enhancement
link: https://github.com/elastic/integrations/pull/4920
- version: "1.2.0"
changes:
- description: CSPM support spaces for 8.7.0
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_security_posture/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: cloud_security_posture
title: "Security Posture Management (CSPM/KSPM)"
version: 1.2.1
version: 1.2.2
release: ga
license: basic
description: "DO NOT USE MAIN TILE (WIP)"
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.