Skip to content

[AWS] Migrate TransitGateway metrics dashboard to lenses #5651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2023
Merged

[AWS] Migrate TransitGateway metrics dashboard to lenses #5651

merged 6 commits into from
Jun 13, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 22, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
transitgateway_before

After:
transitgateway_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-13T13:32:19.274+0000

  • Duration: 54 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.921% (238/277) 👎 -2.968
Lines 85.925% (7387/8597) 👎 -14.075
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review March 23, 2023 00:42
@gpop63 gpop63 requested review from a team as code owners March 23, 2023 00:42
drewdaemon
drewdaemon approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@aspacca
Copy link
Contributor

aspacca commented Mar 27, 2023

@gpop63 , I have the impression your PR will make mine obsolete

Transitgateway metrics are reported with two dimensions:

  • aws.dimensions.TransitGateway
  • aws.dimensions.TransitGatewayAttachment

The sum of the metrics with the same aws.dimensions.TransitGateway value and different aws.dimensions.TransitGatewayAttachment values is equal to the value of the metrics with the same aws.dimensions.TransitGateway value only and empty aws.dimensions.TransitGatewayAttachment.
The dashboard for the integration shows stats at aws.dimensions.TransitGateway level, and not at aws.dimensions.TransitGatewayAttachment. Therefore we have to filter by empty aws.dimensions.TransitGatewayAttachment values, so that the values showed in the dashboard are not doubled respect their reality.

could you please apply the equivalent bugfix changes I did in your new dashboard? ("we have to filter by empty aws.dimensions.TransitGatewayAttachment values")

thanks

@botelastic
Copy link

botelastic bot commented Apr 26, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 26, 2023
@gpop63 gpop63 self-assigned this May 22, 2023
@botelastic botelastic bot removed the Stalled label May 22, 2023
zmoog
zmoog requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: @gpop63 will work with @drewdaemon to address the comments from @aspacca.

I am setting the outcome of this review to "request changes" to make this status explicit.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

@gpop63 gpop63 merged commit e055227 into elastic:main Jun 13, 2023
@elasticmachine
Copy link

Package aws - 1.44.1 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@gpop63 @sodhikirti07
[AWS] Migrate TransitGateway metrics dashboard to lenses (#5651)
08f629c 
* add lenses

* bump package version

* add TransitGatewayAttachment filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gpop63 @elasticmachine @aspacca @zmoog @drewdaemon