Skip to content

[HID Bravura] Converting dashboards to lens #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2023
Merged

[HID Bravura] Converting dashboards to lens #6980

merged 5 commits into from
Jul 17, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jul 17, 2023 •
edited
Loading

What does this PR do?

Bumps format_version to 2.7.0, min version to 8.7.1 and converts all non-lens dashboards to lens.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

hid-event-analysis
hid-log-issues-summary
hid-administrative-disabled-profiles

@P1llus P1llus added enhancement New feature or request Team:Security-External Integrations Integration:hid_bravura_monitor Bravura Monitor (Partner supported) labels Jul 17, 2023
@P1llus P1llus requested a review from a team as a code owner July 17, 2023 13:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-17T17:13:21.398+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 13.636
Classes 100.0% (2/2) 💚 13.636
Methods 92.0% (23/25) 👍 8.667
Lines 98.239% (502/511) 👍 13.236
Conditionals 100.0% (0/0) 💚

bhapas
bhapas reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to add some screenshots?

LGTM otherwise

@P1llus
Copy link
Member Author

P1llus commented Jul 17, 2023

Possible to add some screenshots?

LGTM otherwise

I can add a few, but there is not that much test data, and it has a very large amount of dashboards :) The layout did not really change, even the visualization type (like bar to bar) was kept the same)

@bhapas
Copy link
Contributor

bhapas commented Jul 17, 2023

Possible to add some screenshots?
LGTM otherwise

I can add a few, but there is not that much test data, and it has a very large amount of dashboards :) The layout did not really change, even the visualization type (like bar to bar) was kept the same)

Not really necessary if the visualization layout did not change though.

@P1llus P1llus merged commit 64e08a7 into elastic:main Jul 17, 2023
@elasticmachine
Copy link

Package hid_bravura_monitor - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@P1llus P1llus mentioned this pull request Jul 19, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:hid_bravura_monitor Bravura Monitor (Partner supported)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @bhapas