Skip to content

[Cloud Security] Injest now copies cluster_id -> orchestrator.cluster.id if null (due to pre 8.8.0 agents) #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2023
Merged

[Cloud Security] Injest now copies cluster_id -> orchestrator.cluster.id if null (due to pre 8.8.0 agents) #7185

merged 2 commits into from
Jul 31, 2023

Conversation

mitodrummer
Copy link
Contributor

What does this PR do?

Adds backwards compatibility for the cluster_id field for agents pre 8.8.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@mitodrummer mitodrummer added deprecation Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] Integration:cloud_security_posture Security Posture Management labels Jul 28, 2023
@mitodrummer mitodrummer requested a review from a team as a code owner July 28, 2023 21:32
@mitodrummer mitodrummer mentioned this pull request Jul 28, 2023
Closed
2 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-31T17:21:51.850+0000

  • Duration: 13 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@mitodrummer mitodrummer requested review from a team as code owners July 31, 2023 16:52
@mitodrummer mitodrummer force-pushed the cluster_id_deprecation branch from 632770b to 981409a Compare July 31, 2023 16:56
@mitodrummer mitodrummer requested a review from maxcold July 31, 2023 17:22
@mitodrummer mitodrummer merged commit b0b5325 into main Jul 31, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview28 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@oren-zohar oren-zohar deleted the cluster_id_deprecation branch August 2, 2023 08:21
mitodrummer added a commit that referenced this pull request Aug 10, 2023
@mitodrummer
Backport: [Cloud Security] Injest now copies cluster_id -> orchestrat…
10e9413 
…or.cluster.id if null (due to pre 8.8.0 agents) (#7185)
@mitodrummer mitodrummer linked an issue Aug 10, 2023 that may be closed by this pull request
[Cloud Security] Use orchestrator.cluster.id instead of cluster_id elastic/kibana#155463
Closed
2 tasks
mitodrummer added a commit to mitodrummer/integrations that referenced this pull request Aug 10, 2023
@mitodrummer
Backport: [Cloud Security] Injest now copies cluster_id -> orchestrat…
78c51c0 
…or.cluster.id if null (due to pre 8.8.0 agents) (elastic#7185)
mitodrummer added a commit to mitodrummer/integrations that referenced this pull request Aug 10, 2023
@mitodrummer
Backport: [Cloud Security] Injest now copies cluster_id -> orchestrat…
2679ddf 
…or.cluster.id if null (due to pre 8.8.0 agents) (elastic#7185)
This was referenced Aug 10, 2023
Closed
Closed
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@mitodrummer
Backport: [Cloud Security] Injest now copies cluster_id -> orchestrat…
ffce4a7 
…or.cluster.id if null (due to pre 8.8.0 agents) (#7185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
deprecation Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Use orchestrator.cluster.id instead of cluster_id
3 participants
@mitodrummer @elasticmachine @maxcold