Skip to content

[zeek] - Modified field definitions to use ECS #8062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[zeek] - Modified field definitions to use ECS #8062

merged 1 commit into from
Oct 3, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 3, 2023 •
edited
Loading

Proposed commit message

Modified the field definitions to reference ECS where possible and remove invalid field attributes. By "invalid" I mean these attributes that are allowed in package-spec to avoid a breaking-change but serve no purpose.

[git-generate]
go run github.com/andrewkroh/go-examples/[email protected] \
  -skip-format -fields-yml-use-ecs -fields-yml-cleanup-attrs packages/zeek

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh
[zeek] - Modified field definitions to use ECS
921ddb5 
Modified the field definitions to reference ECS where possible and remove
invalid field attributes.

[git-generate]
go run github.com/andrewkroh/go-examples/[email protected] -skip-format -fields-yml-use-ecs -fields-yml-cleanup-attrs packages/zeek
@elasticmachine
Copy link

elasticmachine commented Oct 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T06:18:32.009+0000

  • Duration: 59 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 254
Skipped 0
Total 254

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh added Integration:zeek Zeek enhancement New feature or request labels Oct 3, 2023
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (43/43) 💚
Files 96.341% (79/82) 👎 -3.659
Classes 96.341% (79/82) 👎 -3.659
Methods 92.021% (692/752) 👍 16.264
Lines 92.055% (8632/9377) 👎 -7.945
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh marked this pull request as ready for review October 3, 2023 21:08
@andrewkroh andrewkroh requested a review from a team as a code owner October 3, 2023 21:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@andrewkroh andrewkroh merged commit 70a8199 into elastic:main Oct 3, 2023
@elasticmachine
Copy link

Package zeek - 2.18.0 containing this change is available at https://epr.elastic.co/search?package=zeek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:zeek Zeek
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @efd6