[pulse_connect_secure] fix duplicate session field #9107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
force-pushed
the
pulse_secure_session_is_short
branch
from
c598c67 to
88edb93
Compare
bhapas
changed the title
|
/test |
bhapas
force-pushed
the
pulse_secure_session_is_short
branch
from
88edb93 to
0c03592
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
3246.75 | 1984.13 | -1262.62 (-38.89%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Package pulse_connect_secure - 1.18.3 containing this change is available at https://epr.elastic.co/search?package=pulse_connect_secure |
andrewkroh
added
the
Integration:pulse_connect_secure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
With #8873 a new field
pulse_secure.sessionis introduced as a keyword. But there is an existing field that namespulse_secure.session.idhaving it as a session object.Hence renaming the new field to
pulse_secure.session.id_short. There is no clear documentation for this field but it has been referred from #8858Checklist
changelog.ymlfile.Related issues