chore: cherry-pick 2f564f1ca07b from angle #48465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
semver/patch
VerteDinde
deleted the
cherry-pick/patch-metal-angle/angle/2f564f1ca07b
branch
|
Release Notes Persisted
|
VerteDinde
added a commit
that referenced
this pull request
Oct 5, 2025
jkleinsc
pushed a commit
that referenced
this pull request
Oct 6, 2025
* chore: add metal patch dir * chore: cherry-pick 2f564f1ca07b from angle (#48465) * chore: update patch
trop bot
added a commit
that referenced
this pull request
Oct 6, 2025
Co-authored-by: Keeley Hammond <[email protected]>
trop bot
added a commit
that referenced
this pull request
Oct 6, 2025
Co-authored-by: Keeley Hammond <[email protected]>
trop bot
added a commit
that referenced
this pull request
Oct 6, 2025
Co-authored-by: Keeley Hammond <[email protected]>
VerteDinde
added a commit
that referenced
this pull request
Oct 6, 2025
* chore: add metal patch dir Co-authored-by: Keeley Hammond <[email protected]> * chore: cherry-pick 2f564f1ca07b from angle (#48465) Co-authored-by: Keeley Hammond <[email protected]> * chore: update patch Co-authored-by: Keeley Hammond <[email protected]> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Keeley Hammond <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Keeley Hammond <[email protected]>
jkleinsc
pushed a commit
that referenced
this pull request
Oct 9, 2025
* chore: add metal patch dir Co-authored-by: Keeley Hammond <[email protected]> * chore: cherry-pick 2f564f1ca07b from angle (#48465) Co-authored-by: Keeley Hammond <[email protected]> * chore: update patch Co-authored-by: Keeley Hammond <[email protected]> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Oct 10, 2025
* chore: add metal patch dir Co-authored-by: Keeley Hammond <[email protected]> * chore: cherry-pick 2f564f1ca07b from angle (#48465) Co-authored-by: Keeley Hammond <[email protected]> * chore: update patch Co-authored-by: Keeley Hammond <[email protected]> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac: handle Metal toolchain being unbundled from Xcode 26
The Metal toolchain was formerly part of Xcode, but in Xcode 26, it has
been unbundled and is now a separate install. Attempting to use the
Metal toolchain without installing it results in a build error, such as:
error: error: cannot execute tool 'metal' due to missing Metal
Toolchain; use: xcodebuild -downloadComponent MetalToolchain
By running the suggested command, the Metal toolchain can be installed,
but the existing angle build does not know how to find it correctly.
For system Xcode installations, tools from the Metal toolchain (
metaland
metallib) can be run viaxcrun. This construct should workequally well for older Xcode versions, for situations where it’s still
in use.
For the hermetic toolchain, we’ll continue splicing the Metal toolchain
into the location it had previously been avialable (see
https://chromium-review.googlesource.com/c/6950738), although this is
subject to change in the future.
Bug: chromium:423933062, chromium:445400016
Change-Id: I139eca51938f7cecfec9b90fd488947160ef4ec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955000
Auto-Submit: Mark Mentovai [email protected]
Commit-Queue: Mark Mentovai [email protected]
Reviewed-by: Geoff Lang [email protected]
Notes: Backported fix for chromium:423933062, chromium:445400016.