[router] Fix useRootNavigationState() error when used in root layout #37023
+179
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
marklawlor
force-pushed
the
marklawlor/sdk-53/fix-useRootNavigationState-root-layout
branch
from
3d3198e to
9f4ef05
Compare
|
Subscribed to pull request
Generated by CodeMention |
marklawlor
force-pushed
the
marklawlor/sdk-53/fix-useRootNavigationState-root-layout
branch
from
9f4ef05 to
1b6d9c8
Compare
expo-bot
added
bot: passed checks
marklawlor
force-pushed
the
marklawlor/sdk-53/fix-useRootNavigationState-root-layout
branch
from
1b6d9c8 to
f7c2fab
Compare
marklawlor
force-pushed
the
marklawlor/sdk-53/fix-useRootNavigationState-root-layout
branch
from
f7c2fab to
ca22265
Compare
marklawlor
deleted the
marklawlor/sdk-53/fix-useRootNavigationState-root-layout
branch
marklawlor
added a commit
that referenced
this pull request
May 26, 2025
…37023) # Why `useRootNavigationState` currently errors with `Warning: TypeError: Cannot read property 'getState' of undefined` when used in the root layout # How Changed to `navigation = navigation.getParent(INTERNAL_SLOT_NAME) || navigation;`. If there is no parent `INTERNAL_SLOT_NAME` then we are in the root navigator. # Test Plan Added unit tests for `useRootNavigationState`
|
@marklawlor Do you have an estimated release date for the version containing this fix? |
gabrieldonadel
added
the
published
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useRootNavigationStatecurrently errors withWarning: TypeError: Cannot read property 'getState' of undefinedwhen used in the root layoutHow
Changed to
navigation = navigation.getParent(INTERNAL_SLOT_NAME) || navigation;. If there is no parentINTERNAL_SLOT_NAMEthen we are in the root navigator.Test Plan
Added unit tests for
useRootNavigationState