Fix: Treat Symbol and function values as empty string in ReactDOMInput #33949
Conversation
|
Hi @pratapmajge! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR fixes how
<input>elements handlevalueanddefaultValuewhen they are provided as aSymbolorfunction. Previously, these values were incorrectly rendered asnullor other unintended values. Now, they are consistently treated as empty strings (""), aligning with expected HTML behavior.Changes
updateInputandinitInputfunctions withinReactDOMInput.jsto convertSymbolandfunctionvalues to"".valueassignments.ReactDOMInput-test.js.Why
This fix resolves inconsistencies between React's internal input handling and browser behavior. It also ensures that controlled and uncontrolled inputs remain predictable when receiving unexpected value types.
Testing
packages/react-dom/src/__tests__/ReactDOMInput-test.jspass.yarn test ReactDOMInputwith all 124 tests passing.Additional Notes