[compiler] Fixes to enableTreatRefLikeIdentifiersAsRefs #34000
+114
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the
@enableTreatRefLikeIdentifiersAsRefs
feature a while back but never enabled it. Since then we've continued to see examples that motivate this mode, so here we're fixing it up to prepare to enable by default. It now works as follows:ref
or-Ref
) and b) the property iscurrent
, we infer the object itself as a ref and the value of the property as a ref value. Originally the feature only detected property loads, not stores.useRef()
. We've seen issues with assuming refs are stable.With this change, cases like the following now correctly error:
Stack created with Sapling. Best reviewed with ReviewStack.