♻️ Clean up legacy code and optimize OpenAPI performance #13874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This scope was kept for compatibility but is no longer used by FastAPI. Removing it reduces WebSocket connection overhead.
Add caching mechanism for default_status_code attribute to avoid repeated signature inspection, improving schema generation performance.
Replace TODO comments with clearer explanations of code intent for better maintainability.
|
Hi 👋 I noticed that the label check failed. Could you please add the appropriate label? This PR is a refactor. ✅ Thanks! |
|
@gudwls215, thanks for your interest and efforts! In general it's better to split changes that are not related to each other into separate PRs to make it easier to review. |
YuriiMotov
changed the title
dolfinus
reviewed
Jul 14, 2025
| @@ -520,7 +516,6 @@ def __init__( | |||
| # would pass the validation and be returned as is. | |||
| # By being a new field, no inheritance will be passed as is. A new model | |||
| # will always be created. | |||
| # TODO: remove when deprecating Pydantic v1 | |||
There was a problem hiding this comment.
Pydantic v1 is not deprecated yet, why removing TODO?
| status_code = str(status_code_param.default) | ||
| # Use cached attribute if available, otherwise fall back to inspection | ||
| # This improves performance by avoiding repeated signature inspection | ||
| if hasattr(current_response_class, "default_status_code"): |
There was a problem hiding this comment.
Neither FastAPI, not Starlette have Response.default_status_code field. How exactly adding this check will affect the performance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up legacy code and implements performance optimizations across the FastAPI codebase, addressing several TODO items and improving code maintainability.
Changes Made
🧹 Legacy Code Cleanup
routing.py): Removed deprecatedfastapi_astackscope that was kept for compatibility but is no longer used_compat.py,routing.py): Updated outdated TODO comments with clearer explanations⚡ Performance Optimizations
openapi/utils.py): Added caching mechanism fordefault_status_codeattribute to reduce repeated signature inspection overheaddefault_status_codeattribute first before falling back to runtime inspection📚 Code Quality Improvements
Performance Impact
Testing
Related Issues
Addresses technical debt items identified in the contributing guidelines analysis:
Type of Change
Checklist