Replace deprecated asyncio.iscoroutinefunction with inspect.iscoroutinefunction
#13890
Conversation
…utinefunction` Deprecated in Python 3.14 and will be removed in Python 3.16.
|
@edgarrmondragon, thanks for your interest! I think it's early to do this refactor. We don't have any warning and without it we will miss occurrences of Do you think it's right time for this? I think we can wait till FastAPI supports Python 3.16 or other versions start to emit deprecation warnings |
That's a good point. Final release of Python 3.14.0 is scheduled for 2025-10-07, and the first RC is only a little over a week away at this point, so I think
are good reasons to do this at this point.
If you want to wait, the earliest I'd recommend is when final 3.14.0 comes out, but that's of course completely up to you. |
There was a problem hiding this comment.
I think we should wait until all pending PRs (or most of them) have been reviewed and merged, then make sure we haven't introduced any new cases where deprecated call is used and then merge this.
Also, we need to check for other deprecated methods used as well.
I think this will happen automatically when Python 3.16 is released and FastAPI officially supports it (will start running tests on Python 3.16)
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Deprecated in Python 3.14 and will be removed in Python 3.16.