Skip to content

fix: enable diagnostics tracking for async error handlers #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
irzix wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: enable diagnostics tracking for async error handlers #6458

irzix wants to merge 3 commits into from
+83 −1

Conversation

@irzix
Copy link

@irzix irzix commented Jan 18, 2026 •
edited
Loading

When an async error handler returns a promise, wrapThenable was called
without the store parameter, causing diagnostics channels to miss async
operations in error handlers.

This fix creates a diagnostics store when channels have subscribers and
passes it to wrapThenable, ensuring consistent diagnostics tracking
across both regular handlers and error handlers.

climba03003
climba03003 reviewed Jan 18, 2026
View reviewed changes
@irzix irzix force-pushed the fix/async-error-handler-diagnostics branch from 8e06e5a to d3921d4 Compare January 18, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climba03003 climba03003 climba03003 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@irzix @climba03003