chore: update logger types and fix TODO comment #6470
+25
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TODO comment incorrectly stated to delete FastifyBaseLogger while also saying to keep only FastifyBaseLogger. It should say to delete FastifyLoggerInstance (the deprecated alias) in the next major release.
…gger FastifyLoggerInstance is deprecated in favor of FastifyBaseLogger. This commit updates imports and type references to use the non-deprecated type.
Tony133
force-pushed
the
chore/update-type-logger-and-comment
branch
from
f7856cd to
4e2772e
Compare
Eomm
approved these changes
Jan 30, 2026
gurgunday
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposals:
Fixes a contradictory TODO comment in
logger.d.ts// TODO delete FastifyBaseLogger in the next major release. It seems that it is enough to have only FastifyBaseLogger.// TODO delete FastifyLoggerInstance in the next major release. It seems that it is enough to have only FastifyBaseLogger.The comment was contradicting itself. The correct intention is to delete
FastifyLoggerInstance(the deprecated alias) ( see commit here: e622c39)Updated imports and type references from
FastifyLoggerInstancetoFastifyBaseLogger, becauseFastifyLoggerInstancehas been deprecated in favor ofFastifyBaseLogger( see screenshot and commit here: f7856cd )The rest will be removed when the
FastifyLoggerInstancetype is permanently removed in the next major release 🚀