fix(validation): correctly update falsy values from validator #6483
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6411.
Currently,
validateParaminlib/validation.jsusesif (ret && ret.value)to decide whether to update the request parameter with the validator's output. If the validator returns a falsy value (e.g.0,"",false), the update is skipped. This affects custom validators or cases where the value is coerced to a falsy value.This PR:
if (ret && ret.value !== undefined)to allow falsy values.test/fix-6411.test.js.anyOfvsnullablefor numbers, asanyOfwithnullas the first branch can lead to unexpected mutation of0tonullin some Ajv configurations.Verified with the new test case.