fix(fcm): Preserve unmapped TopicManagementResponse error reasons#1073
Merged
jonathanedey merged 5 commits intofirebase:masterfrom Nov 19, 2025
Merged
fix(fcm): Preserve unmapped TopicManagementResponse error reasons#1073jonathanedey merged 5 commits intofirebase:masterfrom
TopicManagementResponse error reasons#1073jonathanedey merged 5 commits intofirebase:masterfrom
Conversation
…elpful to use the reason String that came in as an parameter than UNKNOWN_ERROR. UNKNOWN_ERROR could be used for null or empty Strings.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JosRoseboom
changed the title
jonathanedey
requested changes
Nov 17, 2025
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
Thanks @JosRoseboom for putting this together! These changes look good with one comment.
src/main/java/com/google/firebase/messaging/TopicManagementResponse.java
Outdated
Show resolved
Hide resolved
…s added to map them from UPPER_SNAKE_CASE to lower-kebab-case. Entries from the ERROR_CODES that can be computed this way are removed from the map. Extra tests are added for those 3 cases.
jonathanedey
changed the title
TopicManagementResponse error reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains 2 commits that provide a solution for the 2 problems described in #1072