feat(fcm): Add missing WebpushFcmOptions entity (as per documentation)#295
feat(fcm): Add missing WebpushFcmOptions entity (as per documentation)#295hiranya911 merged 4 commits intofirebase:masterfrom kirmerzlikin:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks for working on this @kirmerzlikin. Can you make sure the new class has the following public API:
class WebpushFcmOptions
static Builder builder()
static WebpushFcmOptions withLink(String link)
class Builder
Builder setLink(String link)
WebpushFcmOptions build()
src/main/java/com/google/firebase/messaging/WebpushFcmOptions.java
Outdated
Show resolved
Hide resolved
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@hiranya911 done |
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Approved with a couple of suggestions. Please make those changes, and then I can merge. Also please add an entry to CHANGELOG file.
src/main/java/com/google/firebase/messaging/WebpushFcmOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/messaging/WebpushFcmOptions.java
Outdated
Show resolved
Hide resolved
|
@egilmorez can you review the javadoc-related changes in this PR? |
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Just one nit on one sentence.
|
Thanks @kirmerzlikin. I can merge once you make the change suggested by Eric. |
|
@hiranya911 done |
hiranya911
changed the title
4 participants
WebpushFcmOptions is described in documentation but is not included in Java client.
Corresponding issue - #294
RELEASE NOTE: Added a new
WebpushFcmOptionsAPI for configuring the features provided by the FCM SDK for Web.