feat(fcm): Add FcmOptions on MulticastMessage#439
feat(fcm): Add FcmOptions on MulticastMessage#439hiranya911 merged 1 commit intofirebase:masterfrom pavlospt:feature/multicase-message-fcm-options
Conversation
hiranya911
left a comment
There was a problem hiding this comment.
Thanks for the PR @pavlospt. Looks mostly good. Just a couple of updates needed.
src/main/java/com/google/firebase/messaging/MulticastMessage.java
Outdated
Show resolved
Hide resolved
Hey @hiranya911 thank you for your review. I have updated the PR accordingly 😄 ! |
|
@hiranya911 Sorry for the question, but since this is a thing we will be needing ASAP, I feel like I need to ask 😂 . Do we know when we can have a release including it? 😄 |
|
@pavlospt we can try to get a release out next week. |
|
@hiranya911 cool thank you very much 😄 ! |
|
Hey @hiranya911 is the release still planned to be published this week 😄 ? |
|
This change is now released in v6.14.0 Thank you for your contribution! |
MulticastMessagedoes not seem to supportFcmOptions. This PR introducesFcmOptionsinMulticastMessages.The implementation follows the same approach with the NodeJS SDK.
https://github.com/firebase/firebase-admin-node/blob/master/src/messaging/messaging.ts#L361
Resolves #440