Skip to content

Renamed RespectingRuntimeTypes and RespectingDeclaredTypes to better clarify their purpose #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Renamed RespectingRuntimeTypes and RespectingDeclaredTypes to better clarify their purpose #2866

merged 1 commit into from
Dec 5, 2024

Conversation

dennisdoomen
Copy link
Member

Renamed RespectingRuntimeTypes to PreferringRuntimeMemberTypes and RespectingDeclaredTypes to PreferringDeclaredMemberTypes

Closes #2252

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@dennisdoomen dennisdoomen force-pushed the rename-respecting-runtime-types branch from 660604e to 536bcf5 Compare December 4, 2024 18:50
@dennisdoomen dennisdoomen requested a review from jnyrup December 4, 2024 18:50
@dennisdoomen dennisdoomen force-pushed the rename-respecting-runtime-types branch from 536bcf5 to 6b4da05 Compare December 4, 2024 19:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12166518723

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 12140226245: 0.0%
Covered Lines: 12373
Relevant Lines: 12562
💛 - Coveralls

@dennisdoomen dennisdoomen merged commit b088f1e into fluentassertions:develop Dec 5, 2024
8 checks passed
@dennisdoomen dennisdoomen deleted the rename-respecting-runtime-types branch December 5, 2024 17:27
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 6, 2025
Open
Open
Open
Closed
Open
Open
Open
Open
Closed
Open
Closed
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Closed
Closed
Closed
Closed
Open
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup Awaiting requested review from jnyrup

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop RespectingRuntimeTypes and RespectingDeclaredTypes

3 participants

@dennisdoomen @coveralls @jnyrup