Fix qodana warnings #3053
Merged
Fix qodana warnings #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a leftover from 0a649cb that added polyfill for `string.Split(string separator, StringSplitOptions options = StringSplitOptions.None)`. Before that commit we used the `string[] separator` overload which requires `StringSplitOptions`
jnyrup
commented
May 30, 2025
Comment on lines
+4
to
+6
| #if NET6_0_OR_GREATER || NETSTANDARD2_1 | ||
| using System.Diagnostics.CodeAnalysis; | ||
| #endif |
There was a problem hiding this comment.
This matches how we do conditional using in
fluentassertions/Src/FluentAssertions/AssertionExtensions.cs
Lines 22 to 24 in 68825b1
jnyrup
commented
May 30, 2025
There was a problem hiding this comment.
Other places in this class we just fall through to the return new AndConstraint<TAssertions>((TAssertions)this); right below
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 15350556815Details
💛 - Coveralls |
This was referenced Jul 21, 2025
This was referenced Oct 6, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://github.com/fluentassertions/fluentassertions/actions/runs/14577365118/job/40886331551 we have had a red Qodana pipeline.
The timestamps matches that Github announced a shutdown of an old(er) cache service.
That improved with #3044.
Now it's just 7 warnings, which this PR takes care of.
The removal of
StringSplitOptions.Noneis a leftover from 0a649cb where I introduced and started usingstring.Split(string separator, StringSplitOptions options = StringSplitOptions.None).IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome