Skip to content

refactor(test): remove all test_records.json #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

refactor(test): remove all test_records.json #3151

wants to merge 10 commits into from

Conversation

asmitahase
Copy link
Collaborator

@asmitahase asmitahase commented May 22, 2025 •
edited
Loading

  • All test_records.json are removed from hrms. Most of them were unused anyway, the ones that were used are now refactored to create records in the individual modules
  • Fixed Shift 1 not found error for multiple runs
  • Most tests now can be run multiple times except for the ones that involve holiday lists, they are still created from json files in eprnext
  • Removed unused test dependencies

@asmitahase asmitahase requested a review from ruchamahabal as a code owner May 22, 2025 21:39
@asmitahase asmitahase force-pushed the better-test-suite branch from 7a0a4e5 to 1dc8078 Compare May 22, 2025 21:42
@asmitahase asmitahase marked this pull request as draft May 22, 2025 21:50
@ruthra-kumar
Copy link
Member

Hmm... Failed ones doesn't seem too complex.

Looks like HRMS is lot less dependent on ERPNext for test records than I assumed. Achieving determinism should be easy.

Nice work @asmitahase

@asmitahase asmitahase force-pushed the better-test-suite branch from e1d33cb to 95ea3fc Compare June 2, 2025 03:59
@asmitahase asmitahase marked this pull request as ready for review June 2, 2025 03:59
@asmitahase
Copy link
Collaborator Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 14, 2025

rebase

✅ Branch has been successfully rebased

@asmitahase asmitahase force-pushed the better-test-suite branch 3 times, most recently from 589bdd4 to f41b392 Compare July 14, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal ruchamahabal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmitahase @ruthra-kumar