feat: Added checkbox to exclude specific salary component amount from Journal Entry #3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Jul 8, 2025
There was a problem hiding this comment.
I had tried this but it's used by some users as a feature so could not remove it 😅
#2389
|
can you please add a test and fix the linter issue @iamkhanraheel |
|
Can it be a separate check box then? @ruchamahabal |
AyshaHakeem
reviewed
Jul 18, 2025
| & (ss.name.isin([d.name for d in salary_slips])) | ||
| & ( | ||
| (ssd.do_not_include_in_total == 0) | ||
| | ((ssd.do_not_include_in_total == 1) & (ssd.do_not_include_in_accounts == 0)) |
There was a problem hiding this comment.
do_not_include_in_total check can be removed from this condition? every component has do_not_include_in_total either set to 0 or 1 since those are the only options
There was a problem hiding this comment.
This condition will help to give only those component where do_not_include_in_total is not checked, if it is checked then do_not_include_in_account should be unchecked
iamkhanraheel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
To ensure salary component exclusion from journal entry as per need
Changes Done
Screenshots
no-docs