-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Handle data urls in errors caught by globalHandlersIntegration
#17216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lms24
wants to merge
1
commit into
develop
Choose a base branch
from
lms/fix-browser-long-data-urls
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
pushed a commit
that referenced
this pull request
Jul 31, 2025
- Ref #17216 Because JavaScript can dynamically load code from text like this: ```ts const {dynamicFn} = await import(`data:application/javascript, export function dynamicFn() { throw new Error('Error from data-uri module'); };`); dynamicFn(); ``` You can get slack lines like this: ``` at dynamicFn (data:application/javascript,export function dynamicFn() { throw new Error('Error from data-uri module');};:1:38) ``` These can be huge, often base64 encoded strings. Currently we skip regex parsing on anything over 1k in length but that means we ignore the frame entirely. This PR: - Changes the stack parser so that if the line is over 1k, we still pass the first 1k for parsing - Adds initial check to the Node line parser that special cases truncated lines with data URIs in them
9084de1
to
e26cd1d
Compare
timfish
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test!
I've got another PR incoming that adds the data Uri handling to chrome too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17218 adjusted data URI stack line parsing for most errors that go through the stack parsers (fully for node, line truncation in general). This PR now applies a similar logic to
globalHandlersIntegration
which in some conditions applies a stack frame that doesn't go through the same stack parser.