ref(nestjs): Add mechanism to captured errors
#17312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Aug 5, 2025
| @@ -19,12 +19,12 @@ export const SentryCron = (monitorSlug: string, monitorConfig?: MonitorConfig): | |||
| try { | |||
| result = originalMethod.apply(this, args); | |||
| } catch (e) { | |||
| captureException(e); | |||
| captureException(e, { mechanism: { handled: false, type: 'auto.cron.nestjs' } }); | |||
There was a problem hiding this comment.
(auto.)cron is not a listed category, which is a bit suboptimal. The two alternatives are:
functiongiven we wrap some kind of cron-executed function- omitting the category, since it's not required:
auto.nestjs.sentry_cron
@AbhiPrasad thoughts?
There was a problem hiding this comment.
worth noting: I didn't find a specific span that reliably applies here, so there's no direct span counterpart to this mechanism.type
| @@ -77,7 +77,7 @@ export function SentryExceptionCaptured() { | |||
| return originalCatch.apply(this, [exception, host, ...args]); | |||
| } | |||
|
|
|||
| captureException(exception); | |||
| captureException(exception, { mechanism: { handled: false, type: 'auto.function.nestjs.exception_captured' } }); | |||
There was a problem hiding this comment.
I think auto.function.* is correct here, given this decorator can be applied to any arbitrary function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NestJS SDK didn't add a mechanism to a bunch of caught errors. This resulted in the errors being incorrectly marked as
handled: trueand themechansim.typedefaulting to'generic'.This PR:
captureExceptioncalls within the SDK, marking caught exceptions ashandled: falsehandled: true!mechanism.type, following the naming scheme of trace originI noticed that we have some
startSpancalls in the SDK that don't include asentry.originattribute. I'll open a follow-up PR to fix this separately.ref #17212
closes #17259