Skip to content

Java: Promote Cleartext storage of sensitive information using SharedPreferences from experimental #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 11, 2022
Merged

Java: Promote Cleartext storage of sensitive information using SharedPreferences from experimental #6468

merged 7 commits into from
Jan 11, 2022

Conversation

atorralba
Copy link
Contributor

@atorralba atorralba commented Aug 11, 2021 •
edited
Loading

PR to promote the Cleartext storage of sensitive information using SharedPreferences on Android query created in #4675.

Changes

  • Existing files were moved out of experimental
  • The CleartextStorageSharedPrefsQuery.qll file was created.
  • Refactored tests to use InlineExpectationsTest.
  • Minor improvements in QLDoc and the qhelp file.

To Consider

There were three DataFlow::Confiugration working together in this query: SharedPreferencesFlowConfig, EncryptedValueFlowConfig and EncryptedSharedPrefFlowConfig. I removed EncryptedSharedPrefFlowConfig and used DataFlow::localExprFlow instead, to avoid having that many DataFlow::Configuration instances around.

@atorralba atorralba marked this pull request as ready for review August 11, 2021 13:08
@atorralba atorralba requested a review from a team as a code owner August 11, 2021 13:08
This was referenced Aug 17, 2021
Merged
Merged
Marcono1234
Marcono1234 reviewed Aug 17, 2021
View reviewed changes
@atorralba atorralba force-pushed the atorralba/promote-cleartext-sharedprefs branch from 68f2fcc to 7cd7ffb Compare August 23, 2021 14:55
@atorralba atorralba force-pushed the atorralba/promote-cleartext-sharedprefs branch from 7cd7ffb to da47abc Compare September 3, 2021 11:29
@atorralba
Copy link
Contributor Author

Force pushed to rebase #6493.

@atorralba atorralba added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Nov 11, 2021
ethanpalm
ethanpalm previously approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good from a docs point of view. I just made one small suggestion ⚡

@atorralba
Copy link
Contributor Author

Thanks @ethanpalm! Suggestion applied :)

ethanpalm
ethanpalm previously approved these changes Nov 12, 2021
View reviewed changes
atorralba and others added 4 commits January 10, 2022 17:09
@atorralba
Move from experimental and refactor
55dc783
@atorralba
Fix predicate name
ec8c234
@atorralba @ethanpalm
Apply suggestions from code review
d17e973 
Co-authored-by: Ethan Palm <[email protected]>
@atorralba
Apply suggestions from code review
e1e5e78 
- Update CleartextStorage library to latest refactor
- Move change note to new location
@atorralba atorralba force-pushed the atorralba/promote-cleartext-sharedprefs branch from e30ed41 to e1e5e78 Compare January 10, 2022 16:11
@atorralba atorralba merged commit 4aacba8 into github:main Jan 11, 2022
@atorralba atorralba deleted the atorralba/promote-cleartext-sharedprefs branch January 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

+3 more reviewers

@Marcono1234 Marcono1234 Marcono1234 left review comments

@intrigus-lgtm intrigus-lgtm intrigus-lgtm left review comments

@ethanpalm ethanpalm ethanpalm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Java ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atorralba @Marcono1234 @aschackmull @ethanpalm @intrigus-lgtm