Skip to content

Introduce CODEQL_ACTION_SKIP_SARIF_UPLOAD #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 8, 2025
Merged

Introduce CODEQL_ACTION_SKIP_SARIF_UPLOAD #3180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e0b9da7
Introduce `CODEQL_ACTION_SKIP_SARIF_UPLOAD`
redsun82 Oct 6, 2025
882667e
Update src/util.ts
redsun82 Oct 6, 2025
11e4034
Clarify comment about SKIP_SARIF_UPLOAD setting
redsun82 Oct 6, 2025
680b070
Specify reason for skipping SARIF upload in logs
redsun82 Oct 6, 2025
25c8db9
Revert "Specify reason for skipping SARIF upload in logs"
redsun82 Oct 6, 2025
00a6e13
Tweak SARIF skipping logs
redsun82 Oct 6, 2025
5dfb610
Merge branch 'main' into redsun82/skip-sarif-upload
redsun82 Oct 7, 2025
86b2ad6
Remove unneeded comment
redsun82 Oct 7, 2025
1b09eb4
Address review
redsun82 Oct 7, 2025
df65651
Merge branch 'main' into redsun82/skip-sarif-upload
redsun82 Oct 7, 2025
d05f225
Tweak comment
redsun82 Oct 8, 2025
1707898
Merge branch 'main' into redsun82/skip-sarif-upload
redsun82 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak SARIF skipping logs
  • Loading branch information
@redsun82
redsun82 committed Oct 6, 2025
commit 00a6e13cbfc3c235afc298030cf9b1728b498130
4 changes: 3 additions & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion lib/init-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion lib/upload-lib.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions lib/upload-sarif-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src/upload-lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,9 @@ async function uploadPayload(
actionsUtil.getTemporaryDirectory(),
"payload.json",
);
logger.info(`SARIF upload disabled. Saving to ${payloadSaveFile}`);
logger.info(
`SARIF upload disabled via environment variable. Saving to ${payloadSaveFile}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor:

Suggested change
`SARIF upload disabled via environment variable. Saving to ${payloadSaveFile}`,
`SARIF upload disabled by an environment variable. Saving to ${payloadSaveFile}`,

);
logger.info(`Payload: ${JSON.stringify(payload, null, 2)}`);
fs.writeFileSync(payloadSaveFile, JSON.stringify(payload, null, 2));
return "dummy-sarif-id";
Expand Down
4 changes: 3 additions & 1 deletion src/upload-sarif-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ async function run() {

// We don't upload results in test mode, so don't wait for processing
if (shouldSkipSarifUpload()) {
core.debug("SARIF upload disabled. Waiting for processing is disabled.");
core.debug(
"SARIF upload disabled via environment variable. Waiting for processing is disabled.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"SARIF upload disabled via environment variable. Waiting for processing is disabled.",
"SARIF upload disabled by an environment variable. Waiting for processing is disabled.",

);
} else if (actionsUtil.getRequiredInput("wait-for-processing") === "true") {
if (codeScanningResult !== undefined) {
await upload_lib.waitForProcessing(
Expand Down
Loading