Skip to content

Add a .devcontainer #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

Add a .devcontainer #56

merged 1 commit into from
Mar 1, 2022

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Feb 28, 2022 •
edited by theinterned
Loading

The kitchen sink image for Codespaces comes with node 14 and npm 6. We want to run node 16 and npm 8.

This PR creates a dockerfile and devcontainer to ensure that codespaces come with those newer versions.

Part of https://github.com/github/web-systems/issues/428

@koddsson @theinterned
Add a .devcontainer
08ab459 
Co-authored-by: Ned Schwartz <[email protected]>
@koddsson koddsson requested a review from a team as a code owner February 28, 2022 17:10
@theinterned theinterned merged commit 7b8e6bc into main Mar 1, 2022
@theinterned theinterned deleted the node-16-in-codespaces branch March 1, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jclem jclem Awaiting requested review from jclem jclem was automatically assigned from github/web-systems-reviewers

@JoseInTheArena JoseInTheArena Awaiting requested review from JoseInTheArena JoseInTheArena was automatically assigned from github/web-systems-reviewers

1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koddsson @keithamus @theinterned