Display formatted table when run with gh models eval
#76
Conversation
Yuzuki-S
changed the title
gh models evalgh models eval
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the output formatting for the gh models eval command by replacing plain text output with formatted tables. The changes improve readability by using colored table output to display test results and evaluation details.
- Replaces plain text output with formatted tables using the
tableprinterpackage - Adds color coding (green for passed, red for failed) to improve visual feedback
- Includes table headers and structured layout for evaluation results
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/eval/eval.go | Implements table formatting with color support for test results and evaluation output |
| cmd/eval/eval_test.go | Updates test assertions to accommodate the new table-formatted output structure |
| } | ||
|
|
||
| err := printer.Render() | ||
| if err != nil { |
There was a problem hiding this comment.
Silent error handling by returning early without logging or informing the user that table rendering failed. Consider logging the error or falling back to plain text output.
Copilot uses AI. Check for mistakes.
| } | ||
|
|
||
| err = table.Render() | ||
| if err != nil { |
There was a problem hiding this comment.
Silent error handling by returning early without logging or informing the user that table rendering failed. Consider logging the error or falling back to plain text output.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.