refactor: Remove LLM connection test from RunTestGenerationPipeline

github · pelikhan · Jul 21, 2025 · Jul 21, 2025 · Jul 21, 2025 · Jul 21, 2025
commit 130bc536881742a190303f90f123304ae0773073
@@ -7,6 +7,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/briandowns/spinner"
 	"github.com/github/gh-models/internal/azuremodels"
 )
 
@@ -18,6 +19,11 @@ func (h *generateCommandHandler) callModelWithRetry(step string, req azuremodels
 	h.logLLMRequest(step, req)
 
 	for attempt := 0; attempt <= maxRetries; attempt++ {
+		sp := spinner.New(spinner.CharSets[14], 100*time.Millisecond, spinner.WithWriter(h.cfg.ErrOut))
+		sp.Start()
+		//nolint:gocritic,revive // TODO
+		defer sp.Stop()
+
 		resp, err := h.client.GetChatCompletionStream(ctx, req, h.org)
 		if err != nil {
-		if err != nil {
+
+		resp, err := h.client.GetChatCompletionStream(ctx, req, h.org)
+		if err != nil {
+			sp.Stop() // Ensure spinner is stopped before handling errors
-		if err != nil {
+
+		resp, err := h.client.GetChatCompletionStream(ctx, req, h.org)
+		if err != nil {
+			sp.Stop() // Ensure spinner is stopped before handling errors
 			var rateLimitErr *azuremodels.RateLimitError
@@ -39,10 +45,13 @@ func (h *generateCommandHandler) callModelWithRetry(step string, req azuremodels
 			// For non-rate-limit errors, return immediately
 			return "", err
 		}
+		reader := resp.Reader
+		//nolint:gocritic,revive // TODO
+		defer reader.Close()
-		defer reader.Close()
-		defer reader.Close()
 
 		var content strings.Builder
 		for {
-			completion, err := resp.Reader.Read()
+			completion, err := reader.Read()
 			if err != nil {
 				if errors.Is(err, context.Canceled) || strings.Contains(err.Error(), "EOF") {
 					break

@@ -14,12 +14,6 @@ import (
 func (h *generateCommandHandler) RunTestGenerationPipeline(context *PromptPexContext) error {
 	h.cfg.WriteToOut(fmt.Sprintf("Generating tests for '%s'\n", context.Prompt.Name))
 
-	// test LLM connection
-	err := testConnection(h)
-	if err != nil {
-		return err
-	}
-
 	// Step 1: Generate Intent
 	if err := h.generateIntent(context); err != nil {
 		return fmt.Errorf("failed to generate intent: %w", err)
@@ -95,18 +89,6 @@ func (h *generateCommandHandler) RunTestGenerationPipeline(context *PromptPexCon
 	return nil
 }
 
-func testConnection(h *generateCommandHandler) error {
-	result, err := h.callModelWithRetry("configuration", azuremodels.ChatCompletionOptions{
-		Model:    "openai/gpt-4o-mini", // GitHub Models compatible model
-		Messages: []azuremodels.ChatMessage{{Role: azuremodels.ChatMessageRoleUser, Content: util.Ptr("write a haiku in 5 emojis")}},
-	})
-	if err != nil {
-		return fmt.Errorf("failed to test LLM connection: %w", err)
-	}
-	h.cfg.WriteToOut(fmt.Sprintf("LLM connection test successful: %s\n", result))
-	return nil
-}
-
 // generateIntent generates the intent of the prompt
 func (h *generateCommandHandler) generateIntent(context *PromptPexContext) error {
 	h.cfg.WriteToOut("Generating intent...\n")