Add title field to discussion in get_discussion tool #803
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the title field to the GraphQL query in the get_discussion tool to prevent model hallucination when retrieving GitHub discussion information. The change ensures that discussion titles are properly fetched and included in the response rather than being fabricated by the model.
- Add
titlefield to the GraphQL query structure and response mapping - Update test cases to include title field validation
- Ensure consistent retrieval of discussion metadata
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/discussions.go | Add title field to GraphQL query structure and response mapping |
| pkg/github/discussions_test.go | Update test query string and test data to include title field validation |
tommaso-moro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #802
Overview
This PR adds the discussion
titlefield to the query in theget_discussiontool. Without it, the model seems to hallucinate title information (see screenshot below), and in general this seems like an important field for this toolDemos using this discussion facebook/react#34039
Before (model hallucination)
After (retrieves title correctly)
