Revert "Declare relative-element under React.JSX to fix React 19 compatibility"
#314
+0
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @eramdam |
There was a problem hiding this comment.
Pull Request Overview
Reverts recent additions of React JSX type declarations and related peer dependency settings due to compatibility issues with non-React projects.
- Removes the
declare module 'react'JSX extension inrelative-time-element-define.ts - Deletes
@types/reactpeerDependencies and peerDependenciesMeta entries inpackage.json
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/relative-time-element-define.ts | Stripped out the React JSX declaration and mismatched braces |
| package.json | Removed @types/react peerDependencies and optional metadata |
Comments suppressed due to low confidence (1)
src/relative-time-element-define.ts:25
- The removal of
declare module 'react' {and the closing}for thedeclare globalblock causes unbalanced braces, leading to a syntax error. Reintroduce the module wrapper and ensure all blocks are properly closed.
namespace JSX {
TylerJDev
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #305
These changes turned out to not be compatible with non-react projects (sample test: primer/view_components#3472)
Reverting