Skip to content

Remove text/html; fragment from accept header #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2020
Merged

Remove text/html; fragment from accept header #22

merged 5 commits into from
Mar 11, 2020

Conversation

koddsson
Copy link
Contributor

This is a breaking change and would need a major version bump.

Varnish will choke on ; in a accept header so we need to remove it and only rely on the text/fragment+html header.

Similar to github/auto-complete-element#37

@koddsson koddsson requested a review from a team March 11, 2020 10:51
@koddsson koddsson merged commit 0ef63a8 into master Mar 11, 2020
@koddsson koddsson deleted the remove-fragment-header branch March 11, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @keithamus