Skip to content

fix: for tag update, especially if it already exists #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: for tag update, especially if it already exists #305

merged 1 commit into from
Apr 4, 2025

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@jmeridth jmeridth self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 06:18
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 06:18
@github-actions github-actions bot added the fix label Apr 4, 2025
@jmeridth jmeridth merged commit b55920e into main Apr 4, 2025
9 checks passed
@jmeridth jmeridth deleted the jm_force_tags branch April 4, 2025 06:18
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the updating process for major version tags in the GitHub Actions workflow by force updating the tag to ensure it reflects the latest value, even if it already exists.

  • Replaces the existing tag creation command with one that includes the force flag (-f).
  • Ensures that the major version tag is updated reliably when a previous tag exists.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@jmeridth jmeridth

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmeridth