fix: use vars instead of env (not available at this point) #307
Conversation
Signed-off-by: jmeridth <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue by replacing environment variable references with available workflow variables.
- Updated the display text in the job name to use github.ref instead of github.event.release.tag_name.
- Modified the checkout step to reference the tag using github.event.inputs.TAG_NAME with a fallback to github.ref.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
| @@ -13,14 +13,14 @@ permissions: | |||
| contents: write | |||
| jobs: | |||
| update_tag: | |||
| name: Update the major tag to include the ${{ github.event.inputs.TAG_NAME || github.event.release.tag_name }} changes | |||
| name: Update the major tag to include the ${{ github.event.inputs.TAG_NAME || github.ref }} changes | |||
There was a problem hiding this comment.
Ensure that using github.ref as a fallback returns the expected tag value in all event contexts, as the semantics of github.ref may differ from github.event.release.tag_name.
Copilot uses AI. Check for mistakes.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/[email protected] | ||
| with: | ||
| fetch-tags: true | ||
| ref: ${ TAG_NAME } | ||
| ref: ${{ github.event.inputs.TAG_NAME || github.ref }} |
There was a problem hiding this comment.
Verify that the fallback to github.ref provides the appropriate branch or tag reference for the checkout process in all workflow scenarios.
| ref: ${{ github.event.inputs.TAG_NAME || github.ref }} | |
| ref: ${{ env.BRANCH_OR_TAG_REF }} |
Copilot uses AI. Check for mistakes.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking