[fix] Fix LRO support, add Showcase test. #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes long-standing issues with LRO and adds a Showcase test for them.
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 739 739
Branches 152 152
=====================================
Hits 739 739Continue to review full report at Codecov.
|
| future = echo.wait(wait_request) | ||
| response = future.result() | ||
| assert isinstance(response, showcase_v1alpha3.WaitResponse) | ||
| assert response.content.endswith('the snails...eventually.') |
There was a problem hiding this comment.
I hope it will not hide any Really Serious Error in the beginning of the string :)
alexander-fenster
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes long-standing issues with LRO and adds a Showcase test for them.
The underlying changes are actually in api-core:
Operation.deserialize. google-cloud-python#7427The tests will fail (thus preventing merge) until google-api-core 1.8.0 is released (see googleapis/google-cloud-python#7431).
Fixes #34.