test: add tests for autogen-snippets option #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
software-dov
approved these changes
Nov 1, 2021
| # so always disable snippetgen in that case | ||
| # https://github.com/googleapis/gapic-generator-python/issues/1052 | ||
| options = Options.build("old-naming") | ||
| assert not options.autogen_snippets |
There was a problem hiding this comment.
I think, just for the sake of completeness, it would be good to have a test where both autogen-snippets=True and old-naming are set to make sure that the builder logic handles that correctly.
busunkim96
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
busunkim96
added a commit
that referenced
this pull request
Nov 8, 2021
This reverts commit 185ecc7.
vam-google
pushed a commit
that referenced
this pull request
Nov 8, 2021
busunkim96
added a commit
that referenced
this pull request
Feb 3, 2022
Enable snippetgen for the default (non-Ads) templates. This reverts commit 8bdb709 (which was a revert of #1044 and #1055). I've checked that the changes are OK (don't break generation for any APIs) by creating a [tag](https://github.com/googleapis/gapic-generator-python/commits/v0.62.0b1) and running the [presubmit](https://critique.corp.google.com/cl/424921742).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1044