chore: __init__.py file output is now more deterministic #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort everything that is iteratively produced, e.g. message and enum classes provided.
software-dov
requested review from
a team,
arithmetic1728,
busunkim96 and
vchudnov-g
google-cla
bot
added
the
cla: yes
software-dov
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1649 +41
Branches 328 337 +9
=========================================
+ Hits 1608 1649 +41
Continue to review full report at Codecov.
|
busunkim96
approved these changes
Mar 5, 2021
gcf-merge-on-green
bot
removed
the
automerge
|
I had hoped it would get better once the generation process started using 3.7, where dicts are ordered and the air smells like warm root beer. In any case, being explicit is better. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 12, 2021
Small follow up to #806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort everything that is iteratively produced, e.g. message and enum
classes provided.