Skip to content

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jun 28, 2021

  • Re-add cov-fail-under=100 to unit test sessions to enforce coverage requirement.

  • Remove codecov checks from expected status checks.

  • Add unit test for any_deprecated added in fix: import warnings when needed #930

@busunkim96 busunkim96 requested review from a team as code owners June 28, 2021 16:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2021
@busunkim96
Copy link
Contributor Author

Interestinglyshowcase-unit-3.6 seems to pick up coverage while showcase_unit_alternative_templates-3.7 fails to pick up any coverage. 🤔

@busunkim96 busunkim96 changed the title test: re-add cov-fail-under test: re-add coverage requirement Jun 28, 2021
@busunkim96
Copy link
Contributor Author

@parthea @software-dov I'm not sure why, but doing an editable install -e . seems to make coverage happy again. PTAL.

@busunkim96 busunkim96 merged commit 678def6 into master Jun 29, 2021
@busunkim96 busunkim96 deleted the add-cov-fail-under branch June 29, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants