This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: remove runtime initialization of logger classes#1733
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
meltsufin
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fixes #1696
gax-grpc transitively invokes the
io.netty.util.internal.PlatformDependentclass which leads to InternalLoggerFactory being initialized.InternalLoggerFactory. As described here,InternalLoggerFactoryfirst choosesSlf4jLoggerFactoryas the default logger factory and if slf4j is not present then it choosesLog4JLoggerFactoryand so on. This results inio.grpc.netty.shaded.io.netty.util.internal.logging.Slf4JLoggerFactoryandio.grpc.netty.shaded.io.netty.util.internal.logging.Log4JLoggerbeing initialized and can sometimes lead to the following warning by graal during native image compilation (when slf4j is not present on the classpath):To avoid this warning, we initially followed the instructions to initialize these classes at runtime. While this behaves fine when there is no slf4j or log4j dependency on the classpath, this breaks behavior when these logging dependencies are actually added.
Reproducer: https://github.com/mpeddada1/simple-netty-test/blob/main/README.md