Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

fix(test): testThrottlingBlocking flakyness fix #1775

Merged
diegomarquezp merged 2 commits into from
Aug 22, 2022
Merged

fix(test): testThrottlingBlocking flakyness fix #1775

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bffb72d
fix(test): testThrottlingBlocking flakyness fix
diegomarquezp Aug 16, 2022
8f34c53
fix(test): remove unnecessary timeout in verify
diegomarquezp Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(test): remove unnecessary timeout in verify
  • Loading branch information
@diegomarquezp
diegomarquezp committed Aug 16, 2022
commit 8f34c53afbfa2a517b0683c1c8a34113d0fa175e
4 changes: 2 additions & 2 deletions gax/src/test/java/com/google/api/gax/batching/BatcherImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,9 +892,9 @@ public void run() {
assertWithMessage("adding elements to batcher should not be blocked").fail();
}

// Mockito recommends using verify() as the ONLY recommended way to interact with Argument
// Mockito recommends using verify() as the ONLY way to interact with Argument
// captors - otherwise it may incur in unexpected behaviour
Mockito.verify(callContext, Mockito.timeout(0)).withOption(key.capture(), value.capture());
Mockito.verify(callContext).withOption(key.capture(), value.capture());

// Verify that throttled time is recorded in ApiCallContext
assertThat(key.getValue()).isSameInstanceAs(Batcher.THROTTLED_TIME_KEY);
Expand Down