Show error message in case of problems with getting access token#206
Merged
chingor13 merged 1 commit intogoogleapis:masterfrom Nov 12, 2018
Merged
Show error message in case of problems with getting access token#206chingor13 merged 1 commit intogoogleapis:masterfrom
chingor13 merged 1 commit intogoogleapis:masterfrom
Conversation
Currently it's unclear what caused the problem with it
Contributor
Author
|
@chingor13, could you please take a look on it? It'll help to diagnose credentials-related problems. |
chingor13
approved these changes
Nov 12, 2018
Contributor
chingor13
left a comment
There was a problem hiding this comment.
For future reference, the original IOException is contained as the cause of the newly thrown one. If you catch the IOException you can call getCause() to get the original exception.
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage ? 75.84%
Complexity ? 313
=========================================
Files ? 20
Lines ? 1354
Branches ? 148
=========================================
Hits ? 1027
Misses ? 254
Partials ? 73
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in case of problems with token refresh is unclear what caused the problem and this change brings additional details.
Related to JetBrains/teamcity-google-storage#9