Fix#228 update default metadata url#230
Merged
sduskis merged 1 commit intogoogleapis:masterfrom Mar 25, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
Coverage ? 78.26%
Complexity ? 329
=========================================
Files ? 21
Lines ? 1445
Branches ? 158
=========================================
Hits ? 1131
Misses ? 236
Partials ? 78
Continue to review full report at Codecov.
|
sduskis
reviewed
Mar 8, 2019
|
|
||
| // Note: the explicit IP address is used to avoid name server resolution issues. | ||
| static final String DEFAULT_METADATA_SERVER_URL = "http://169.254.169.254"; | ||
| static final String DEFAULT_METADATA_SERVER_URL = "http://metadata.google.internal"; |
Contributor
There was a problem hiding this comment.
Please use metadata.google.internal. with the . at the end. We need that to solve a nasty problem in docker related to that problem.
Contributor
Author
There was a problem hiding this comment.
We had this issue #4269 and its fixed with http://metadata.google.internal for GKE and GCE both.
sduskis
approved these changes
Mar 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228