Update dependencies versions#234
Merged
sduskis merged 2 commits intogoogleapis:masterfrom Mar 25, 2019
Merged
Conversation
merge master
googlebot
added
the
cla: yes
sduskis
approved these changes
Mar 25, 2019
Contributor
Author
|
It's possible the "Kokoro - Test: Java 8" job is wedged somehow or not reporting status. Both this PR and the much simpler #233 have been stuck at "Expected — Waiting for status to be reported" for a while now. |
sduskis
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage ? 78.26%
Complexity ? 329
=========================================
Files ? 21
Lines ? 1445
Branches ? 158
=========================================
Hits ? 1131
Misses ? 236
Partials ? 78Continue to review full report at Codecov.
|
elharo
commented
Mar 25, 2019
Contributor
Author
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
Looks good. I don't have permission to merge this one. Please merge when you get a minute.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves Guava and AppEngine API SDK forward.
It resolves a minor inconsistency in the version definition for the AppEngine API SDK.
It also moves the google-http-java-client backwards to 1.27.0 because 1.28.0 made an incompatible change that breaks google-cloud-java (which depends on 1.27.0) and using 1.28.0 here risks runtime problems down the line.