Skip to content

feat(run): generate library #9460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbolduc merged 4 commits into from
Jul 13, 2022
Merged

feat(run): generate library #9460

dbolduc merged 4 commits into from
Jul 13, 2022

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 12, 2022 •
edited by coryan
Loading

Fixes #9446

The changes to cmake/CompileProtos.cmake were required because Cloud Run has a k8s.min.proto. Previously, we would parse the basename as: k8s not k8s.min.

Also, we use a custom endpoint name so it doesn't conflict with

google-cloud-cpp/google/cloud/appengine/doc/main.dox

Lines 67 to 69 in 4be7b7e

- `GOOGLE_CLOUD_CPP_SERVICES_ENDPOINT=...` overrides the
`EndpointOption` (which defaults to "appengine.googleapis.com")
used by `MakeServicesConnection()`.

This change is Reviewable

@product-auto-label product-auto-label bot added the api: run Issues related to the Cloud Run API. label Jul 12, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 12, 2022

Google Cloud Build Logs
For commit: 6f96b5d338f70edee13db41b79fb657c9183bd14

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 12, 2022 •
edited
Loading

Codecov Report

Merging #9460 (6f96b5d) into main (ead714b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9460      +/-   ##
==========================================
- Coverage   94.63%   94.63%   -0.01%     
==========================================
  Files        1486     1486              
  Lines      136696   136696              
==========================================
- Hits       129369   129364       -5     
- Misses       7327     7332       +5
Impacted Files Coverage Δ
...loud/bigtable/internal/connection_refresh_state.cc 97.22% <0.00%> (-2.78%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.68%) ⬇️
google/cloud/internal/curl_impl.cc 91.87% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead714b...6f96b5d. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review July 13, 2022 02:50
@dbolduc dbolduc requested a review from a team as a code owner July 13, 2022 02:50
@coryan
Copy link
Contributor

coryan commented Jul 13, 2022

Linking the functions framework from the README is a great idea

@dbolduc dbolduc merged commit dc0fb06 into googleapis:main Jul 13, 2022
@dbolduc dbolduc deleted the feat-run-generate-library branch July 13, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

api: run Issues related to the Cloud Run API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate library for run.googleapis.com

3 participants

@dbolduc @google-cloud-cpp-bot @coryan