Skip to content

fix(assuredworkloads): reenable on windows #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbolduc merged 1 commit into from
Jul 14, 2022
Merged

fix(assuredworkloads): reenable on windows #9467

dbolduc merged 1 commit into from
Jul 14, 2022

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 13, 2022 •
edited
Loading

Probably fixes #8198

We require protobuf >=21.1, which handles STATUS_PENDING: https://github.com/protocolbuffers/protobuf/blob/7062d0a2d0075d5e7d5c294fd3984df67a976da3/src/google/protobuf/port_def.inc#L848-L849

This change is Reviewable

@product-auto-label product-auto-label bot added the api: assuredworkloads Issues related to the Assured Workloads API. label Jul 13, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 13, 2022

Google Cloud Build Logs
For commit: 1461973809fc654627f8d076963b8994d2e750ac

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #9467 (1461973) into main (78e6c18) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9467   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1485     1485           
  Lines      136689   136689           
=======================================
+ Hits       129364   129368    +4     
+ Misses       7325     7321    -4
Impacted Files Coverage Δ
...bigtable/examples/bigtable_hello_instance_admin.cc 80.00% <0.00%> (-2.00%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.59% <0.00%> (+1.00%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.31% <0.00%> (+1.12%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e6c18...1461973. Read the comment docs.

@dbolduc dbolduc added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 14, 2022
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022
@dbolduc dbolduc marked this pull request as ready for review July 14, 2022 16:25
@dbolduc dbolduc requested a review from a team as a code owner July 14, 2022 16:25
@dbolduc
Copy link
Member Author

dbolduc commented Jul 14, 2022

Result of manually triggering cmake-release: https://source.cloud.google.com/results/invocations/9834453e-d4db-467f-963f-83336cf490ad

@dbolduc dbolduc merged commit d63c0b2 into googleapis:main Jul 14, 2022
@dbolduc dbolduc deleted the reenable-assuredworkloads-on-windows branch July 14, 2022 16:55
@dbolduc
Copy link
Member Author

dbolduc commented Jul 14, 2022

Merging, and if the CI breaks, I will accept the consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: assuredworkloads Issues related to the Assured Workloads API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable google/cloud/assuredworkloads on Windows

3 participants

@dbolduc @google-cloud-cpp-bot @devbww