fix(asset): reenable on macOS #9468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudasset
Collaborator
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9468 +/- ##
==========================================
- Coverage 94.63% 94.63% -0.01%
==========================================
Files 1489 1489
Lines 137195 137195
==========================================
- Hits 129838 129835 -3
- Misses 7357 7360 +3
Continue to review full report at Codecov.
|
dbolduc
force-pushed
the
reenable-asset-on-macos
branch
from
01938aa to
0280216
Compare
Collaborator
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8145
We require protobuf >= 21.1, which handles
TRUEandFALSEmacros: https://github.com/protocolbuffers/protobuf/blob/7062d0a2d0075d5e7d5c294fd3984df67a976da3/src/google/protobuf/port_def.inc#L861-L864We leave the bazel windows build disabled. There is a comment in the linked issue about what breaks.
This change is